On Mon, 2012-02-27 at 11:16 +1100, David Gibson wrote: > > > If the kernel page size is larger than TARGET_PAGE_SIZE, which > > > happens for example on ppc64 with kernels compiled for 64K pages, > > > the dirty tracking doesn't work. > > > > I think a better solution would be to push this to memory API and > > underlying exec.c dirty tracking so that they use the same page size > > as kernel (only in this KVM case, in general dirty tracking should > > match TARGET_PAGE_SIZE granularity).
That sounds horrible... you propose a -MUCH- more invasive change to a nasty & complex core piece of code to deal with what is fixed by a 2-liner patch ? Cheers, Ben.
