Re: [PATCH 5/8] spapr: Clean up local variable shadowing in spapr_get_fw_dev_path()

[Philippe Mathieu-Daudé]

On 18/9/23 16:58, Cédric Le Goater wrote:

Rename PCIDevice variable to avoid this warning :

   ../hw/ppc/spapr.c: In function ‘spapr_get_fw_dev_path’:
   ../hw/ppc/spapr.c:3217:20: warning: declaration of ‘pcidev’ shadows a 
previous local [-Wshadow=compatible-local]
    3217 |         PCIDevice *pcidev = CAST(PCIDevice, dev, TYPE_PCI_DEVICE);
         |                    ^~~~~~
   ../hw/ppc/spapr.c:3147:16: note: shadowed declaration is here
    3147 |     PCIDevice *pcidev = CAST(PCIDevice, dev, TYPE_PCI_DEVICE);
         |                ^~~~~~

Signed-off-by: Cédric Le Goater <c...@kaod.org>
---
  hw/ppc/spapr.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>