On Fri, 15 Sep 2023 09:48:08 -0400 "Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Tue, Sep 05, 2023 at 02:56:46PM +0800, Zhao Liu wrote: > > Hi Michael, > > > > On Fri, Sep 01, 2023 at 12:55:33PM +0300, Michael Tokarev wrote: > > > Date: Fri, 1 Sep 2023 12:55:33 +0300 > > > From: Michael Tokarev <m...@tls.msk.ru> > > > Subject: Re: [PATCH 00/16] tests: Add CPU topology related smbios test > > > cases > > > > > > 25.08.2023 06:36, Zhao Liu wrote: > > > > From: Zhao Liu <zhao1....@intel.com> > > > > > > > > Hi all, > > > > > > > > This patchset is the follow up tests of previous topology fixes in > > > > smbios [1]. > > > > > > > > In this patchset, add these test cases: > > > > > > > > 1. Add the case to test 2 newly added topology helpers (patch 1): > > > > * machine_topo_get_cores_per_socket() > > > > * machine_topo_get_threads_per_socket() > > > > > > > > 2. Add the cases in bios-tables-test.c to: > > > > * test smbios type4 table count (patch 2-4). > > > > * test smbios type4 core count field (patch 5-7). > > > > * update the test of smbios type4 core count2 field (patch 8-10). > > > > * test smbios type4 thread count (patch 11-13). > > > > * test smbios type4 thread count2 (patch 14-16). > > > > > > > > With the above new cases, cover all commits of [1] in test. > > > > > > > > [1]: > > > > https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html > > > > > > Hmm. I definitely didn't expect such a large patchset.. I asked for just > > > a small, maybe manual (from command-line) reproducer of the original > > > issue, > > > so I can verify it is fixed before applying the change in question to qemu > > > stable trees. > > > > Since these issues are found by coding reading, they are "byproducts" of > > other topology-related work I've been woring on, not directly identified > > by any anomaly... > > > > ...So I'm not quite sure what the consequences of these few misuses of > > topology fields are, and how they might manifest themselves. > > > > > It is a large work. Lemme at least give it a try in the > > > gitlab CI... > > > > The test cases are the ones that clearly define the relevant topology > > issues. > > > > > > Thanks, > > Zhao > > I think it's ok, as long as Igor's happy. series looks fine to me (modulo cosmetic issues and better commit messages as noted in per patch review) > > > > > > > Philippe, can you pick this up for the misc tree? > > > > > > /mjt >
