Hi On Fri, Sep 8, 2023 at 3:55 AM Laszlo Ersek <ler...@redhat.com> wrote: > > On 9/8/23 01:47, Laszlo Ersek wrote: > > > I don't know why qemu_console_is_multihead() used a lot of QOM > > trickery for this in the first place, but here's what I'd propose as > > fix -- simply try to locate a QemuGraphicConsole in "consoles" that > > references the same "device" that *this* QemuGraphicConsole > > references, but by a different "head" number. > > So, the final version of the function would look like: > > static bool qemu_graphic_console_is_multihead(QemuGraphicConsole *c) > { > QemuConsole *con; > > QTAILQ_FOREACH(con, &consoles, next) { > if (!QEMU_IS_GRAPHIC_CONSOLE(con)) { > continue; > } > QemuGraphicConsole *candidate = QEMU_GRAPHIC_CONSOLE(con); > if (candidate->device != c->device) { > continue; > } > > if (candidate->head != c->head) { > return true; > } > } > return false; > } >
ack, can you send a patch?