On Wed, Aug 30, 2023 at 01:37:59PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > Although at this point only QemuGraphicConsole have hw_ops that > implements ui_info() callback, it makes sense to keep the code in the > base QemuConsole, to simplify conditions for the caller. > > As of now, the code didn't reach a NULL timer because dpy_set_ui_info() > checks if dpy_ui_info_supported() (hw_ops->ui_info != NULL), which is > false for text_console_ops. This is a bit fragile, let simply allocate > and free the timer in the base class. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > ui/console.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
