On 07.08.23 10:10, Ilya Leoshkevich wrote:
On Sat, 2023-08-05 at 10:02 +0200, David Hildenbrand wrote:
On 05.08.23 01:03, Ilya Leoshkevich wrote:
Currently the emulation of VSTRS recognizes partial matches in
presence
of \0 in the haystack, which, according to PoP, is not correct:

      If the ZS flag is one and a zero byte was detected
      in the second operand, then there can not be a
      partial match ...

Add a check for this. While at it, fold a number of explicitly
handled
special cases into the generic logic.

Can we split that off? Or doesn't it make sense to split it off after
fixing the issue?

I could do this if this is important, e.g., for stable, but I came to
the conclusion that I needed to get rid of the special cases after I
had to add the new check to more than one place.

Okay, so let's keep it as is.

Fortunately you heavily test that code! :)

Acked-by: David Hildenbrand <da...@redhat.com>

--
Cheers,

David / dhildenb


Reply via email to