On Mon, Aug 14, 2023 at 11:54:27AM -0700, Steve Sistare wrote:
> +void vm_wakeup(void)
> +{
> + if (!vm_started) {
> + vm_start();
(irrelevant of the global var that I wanted to remove..)
Calling vm_start() is wrong here, IMHO.
I think we need to notify everyone on the wakeup before really waking up
the vcpus:
notifier_list_notify(&wakeup_notifiers, &wakeup_reason);
There's resume_all_vcpus() after that. I don't know the side effect of
resuming vcpus without such notifications, at least some acpi fields do not
seem to be updated so the vcpu can see stale values (acpi_notify_wakeup()).
> + } else {
> + runstate_set(RUN_STATE_RUNNING);
> }
> }
--
Peter Xu
