On Wed, Aug 16, 2023 at 06:20:58PM -0300, Fabiano Rosas wrote: > > One more thing to mention is, now I kind of agree probably we should > > register yank over each qemufile, as you raised the concern in the other > > thread that otherwise qmp_yank() won't set error for the qemufile, which > > seems to be unexpected. > > I haven't made up my mind yet, but I think I'd rather stop setting that > error instead of doing it from other places. A shutdown() is mostly a > benign operation intended to end the connection. The fact that we use it > in some cases to kick the thread out of a possible hang doesn't seem > compelling enough to set -EIO. > > Of course we currently have no other way to indicate that the file was > shutdown, so the -EIO will have to stay and that's a discussion for > another day.
Yes, if we can avoid setting -EIO at all when shutdown that'll also be good, maybe making more sense. Thanks, -- Peter Xu
