On Mon, Feb 20, 2012 at 12:41:09PM +0100, Gerd Hoffmann wrote: > On 02/19/12 22:28, Alon Levy wrote: > > Add an implementation of the DisplayAllocator callbacks for qxl. Uses > > the QEMU_ALLOCATED_FLAG to ensure vga/vga_draw_graphic does the 24 to 32 > > bits per pixel line convertion. Since free/resize/create are defined in > > qxl.c, it is easy to ensure consistent usage of the flag (it means > > QXL_ALLOCATED basically). > > > > With this patch and the previous two screendump works for vga and qxl > > modes when using qxl and spice together. This might break sdl/vnc with > > spice, untested since it isn't of known use. > > Breaking vnc+spice being used in parallel breaking is exactly what I > suspect might be possible. IIRC there where discussions about just > enabling both vnc+spice, then let users pick what to use, so I'd prefer > to not break this.
I'll send a series that works with vnc+spice and sdl+spice (didn't test sdl+vnc+spice), and screendumps at the same time. > > Setting the QEMU_ALLOCATED_FLAG flag sounds hackish too. So you think I should introduce a new flag? I could introduce a QEMU_DISPLAYSURFACE_MAX and then use QEMU_DISPLAY_SURFACE_MAX<<1 for my own flag. Actually I think the right thing is to move/copy the 24bit->32bit convertion from vga.c to pflib.c, what do you think? > > cheers, > Gerd >
