04.08.2023 16:41, Richard Henderson wrote:
On 8/4/23 02:02, Michael Tokarev wrote:
01.08.2023 00:02, Richard Henderson wrote:
..
+ qatomic_set_mb(rb_link, node);
FWIW, there's no qatomic_set_mb() in 8.0 and before, so this can not be
directly applied to stable-8.0. This commit is missing in 8.0 before
qatomic_set_mb() can be used:
commit 06831001ac8949b0801e0d20c347d97339769a20
Author: Paolo Bonzini <[email protected]>
Date: Fri Mar 3 14:37:51 2023 +0100
atomics: eliminate mb_read/mb_set
I don't think it's a good idea to back-port this commit to stable-8.0.
How do you think we can solve this for 8.0?
The function is called qatomic_mb_set instead of qatomic_set_mb in stable-8.0.
Sure, qatomic_mb_set has been renamed to qatomic_set_mb by the commit I
quoted above. It is just a bit awkward to rename the user like this
when back-porting, especially since the commit subject mentions the
new name already. It was my first thought to use the old name, but
I thought I'd ask first.
Ok, let's rename the function call in this patch, but keep everything
else (incl. the subject) intact. I've added comment about this though.
Thanks!
/mjt
