Hi C. > On July 31, 2023 3:26 PM, Cédric Le Goater <c...@redhat.com> wrote: > > On 7/31/23 05:57, Liu, Jing2 wrote: > > Hi C. > > > >> On July 28, 2023 4:44 PM, Cédric Le Goater <c...@redhat.com> wrote: > >> > >> [ ... ] > >> > >>> Sorry I didn't quite understand "info.flags be tested against > >> VFIO_IRQ_INFO_NORESIZE". > >>> I saw kernel < 6.4 simply added NORESIZE to info.flags and latest > >>> kernel adds > >> if has_dyn_msix. > >>> Would you please kindly describe more on your point? > >> > >> I was trying to find the conditions to detect safely that the kernel > >> didn't have dynamic MSI-X support. Testing VFIO_IRQ_INFO_NORESIZE > seems enough. > >> > > Oh, I see. > > > >>>> In that case, QEMU should report an error and the trace event is > >>>> not > >> needed. > >>> > >>> I replied an email with new error handling draft code based on my > >>> understanding, which reports the error and need no trace. Could you > >>> please > >> help review if that is what we want? > >> > >> yes. It looked good. Please send a v1 ! > > > > Thanks for reviewing that. I guess you mean v2 for next version 😊 > > Well, if you remove the RFC status, I think you should, this would still be a > v1. > Oh, got it. Thanks for telling this.
Jing > Thanks, > > C.
