On Fri, 28 Jul 2023 at 21:47, Daniel Henrique Barboza <danielhb...@gmail.com> wrote: > > Use g_free(table[i]) instead of free(table[i]) to comply with QEMU low > level memory management guidelines. > > Signed-off-by: Daniel Henrique Barboza <danielhb...@gmail.com> > --- > target/ppc/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/ppc/translate.c b/target/ppc/translate.c > index e6a0709066..d90535266e 100644 > --- a/target/ppc/translate.c > +++ b/target/ppc/translate.c > @@ -7129,7 +7129,7 @@ static int test_opcode_table(opc_handler_t **table, int > len) > tmp = test_opcode_table(ind_table(table[i]), > PPC_CPU_INDIRECT_OPCODES_LEN); > if (tmp == 0) { > - free(table[i]); > + g_free(table[i]); > table[i] = &invalid_handler; > } else { > count++;
Where is the allocation that this memory is free()ing? I think it is the g_new() in create_new_table(), but the code is a little complicated for me to understand... thanks -- PMM