On Thu, 27 Jul 2023 at 22:32, Chris Laplante <ch...@laplante.io> wrote: > > > > (g_strcmp0() can handle the NULL case without having > > to special case it -- this is how qdev_get_named_gpio_list() > > finds entries in the ngl list.) > > > > Apologies for not noticing that on the first round of review. > > No worries - it makes the code much simpler anyway. Should we bother > factoring out qtest_install_gpio_out_intercept still? It is only used in one > place now, as before.
I'd keep the function, I think, since you've already written it. It's kind of usefully documenting of the intent. -- PMM
