On Fri, Jul 21, 2023 at 10:54:43AM +0200, Philippe Mathieu-Daudé wrote: > On 21/7/23 09:31, Philippe Mathieu-Daudé wrote: > > On 21/7/23 08:06, Bastian Koppelmann wrote: > > > this name is used by capstone and will lead to a build failure of QEMU, > > > when capstone is enabled. So we rename it to tricore_has_feature(), to > > > match has_feature() in translate.c. > > > > > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1774 > > > Signed-off-by: Bastian Koppelmann <kbast...@mail.uni-paderborn.de> > > > --- > > > target/tricore/cpu.c | 8 ++++---- > > > target/tricore/cpu.h | 2 +- > > > target/tricore/helper.c | 4 ++-- > > > target/tricore/op_helper.c | 4 ++-- > > > 4 files changed, 9 insertions(+), 9 deletions(-) > > > > Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org> > > BTW Bastian if you want I can squeeze this single patch in > my mips-fixes PR I'm planning.
Thanks, Phil. Go ahead. Cheers, Bastian