On Thu, 20 Jul 2023 at 17:42, Cédric Le Goater <c...@kaod.org> wrote: > > On 7/20/23 17:59, Peter Maydell wrote: > > In the aspeed_rtc device we store a difference between two time_t > > values in an 'int'. This is not really correct when time_t could > > be 64 bits. Enlarge the field to 'int64_t'. > > > > This is a migration compatibility break for the aspeed boards. > > While we are changing the vmstate, remove the accidental > > duplicate of the offset field. > > Ah yes. Thanks. > > > > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > > Reviewed-by: Cédric Le Goater <c...@kaod.org> > > > > --- > > I took "bump the migration version" as the simplest approach > > here, because I don't think we care about migration compat > > in this case. If we do I can write the alternate version of > > the patch... > > > I don't think we care much about migration compat and fyi, migration > of aspeed machines broke a while ago. It still migrates if done before > Linux is loaded.
Is that the "migration of AArch32 Secure state doesn't work properly" bug, or am I misremembering? -- PMM
