On Thu, Jul 20, 2023 at 04:30:38PM +0100, Peter Maydell wrote:
> The POSIX definition of the 'read' utility requires that you
> specify the variable name to set; omitting the name and
> having it default to 'REPLY' is a bashism. If your system
> sh is dash, then it will print an error message during build:
> 
> qemu/pc-bios/s390-ccw/../../scripts/git-submodule.sh: 106: read: arg count
> 
> Specify the variable name explicitly.
> 
> Fixes: fdb8fd8cb915647b ("git-submodule: allow partial update of 
> .git-submodule-status")
> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
> ---
>  scripts/git-submodule.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Reply via email to