On Tue, 6 Jun 2023 at 15:34, Paolo Bonzini <pbonz...@redhat.com> wrote:
>
> Allow a specific subdirectory to run git-submodule.sh with only a
> subset of submodules, without removing the others from the
> .git-submodule-status file.
>
> This also allows scripts/git-submodule.sh to be more lenient:
> validating an empty set of submodules is not a mistake.
>
> Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
I've noticed that when doing a build sometimes this
script now produces an error:
make: Entering directory
'/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/clang'
/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/pc-bios/s390-ccw/../../scripts/git-submodule.sh:
106: read: arg count
[1/154] Generating qemu-version.h with a custom command (wrapped by
meson to capture output)
[etc]
> - $GIT submodule status $modules > "${substat}"
> - test $? -ne 0 && update_error "failed to save git submodule status" >&2
> + (while read -r; do
This is because "read" without a variable name argument is
a non-POSIX extension. I think the fix to this is to say
"read -r REPLY" rather than omitting the variable name and
assuming it will default to REPLY.
> + for module in $modules; do
> + case $REPLY in
> + *" $module "*) continue 2 ;;
> + esac
> + done
> + printf '%s\n' "$REPLY"
> + done
I'll send a patch shortly.
thanks
-- PMM
