On Thu, Jul 13, 2023 at 11:07 PM Joelle van Dyne <j...@getutm.app> wrote: > > On Thu, Jul 13, 2023 at 10:20 AM Stefan Berger <stef...@linux.ibm.com> wrote: > > > > The ppi command line option for the TIS device on sysbus never worked > > and caused an immediate segfault. Remove support for it since it also > > needs support in the firmware and needs testing inside the VM. > > > > Reproducer with the ppi=on option passed: > > > > qemu-system-aarch64 \ > > -machine virt,gic-version=3 \ > > -m 4G \ > > -nographic -no-acpi \ > > -chardev socket,id=chrtpm,path=/tmp/mytpm1/swtpm-sock \ > > -tpmdev emulator,id=tpm0,chardev=chrtpm \ > > -device tpm-tis-device,tpmdev=tpm0,ppi=on > > [...] > > Segmentation fault (core dumped) > > > > Signed-off-by: Stefan Berger <stef...@linux.ibm.com> > > Do you need to add a VMSTATE_UNUSED_TEST in case a future QEMU version > introduces a new field in the same position which will cause an issue > when restoring from an older version?
Actually, ignore that last message. I misread the patch thinking it's on the VMState.
