~hyman <hy...@git.sr.ht> writes:
> From: Hyman Huang(黄勇) <yong.hu...@smartx.com>
>
> Extend query-migrate to provide throttle time and estimated
> ring full time with dirty-limit capability enabled, through which
> we can observe if dirty limit take effect during live migration.
>
> Signed-off-by: Hyman Huang(黄勇) <yong.hu...@smartx.com>
> Reviewed-by: Markus Armbruster <arm...@redhat.com>
> Reviewed-by: Juan Quintela <quint...@redhat.com>
[...]
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 031832cde5..97f7d0fd3c 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -250,6 +250,18 @@
> # blocked. Present and non-empty when migration is blocked.
> # (since 6.0)
> #
> +# @dirty-limit-throttle-time-per-round: Maximum throttle time
> +# (in microseconds) of virtual CPUs each dirty ring full round,
> +# which shows how MigrationCapability dirty-limit affects the
> +# guest during live migration. (since 8.1)
Two spaces after sentence-ending punctuation, please:
# guest during live migration. (since 8.1)
Same below.
> +#
> +# @dirty-limit-ring-full-time: Estimated average dirty ring full
> +# time (in microseconds) each dirty ring full round. The value
> +# equals dirty ring memory size divided by average dirty page
> +# rate of the virtual CPU, which can be used to observe the
> +# average memory load of the virtual CPU indirectly. Note that
> +# zero means guest doesn't dirty memory (since 8.1)
Last sentence should end with with a period.
Together:
# @dirty-limit-throttle-time-per-round: Maximum throttle time (in
# microseconds) of virtual CPUs each dirty ring full round, which
# shows how MigrationCapability dirty-limit affects the guest
# during live migration. (Since 8.1)
#
# @dirty-limit-ring-full-time: Estimated average dirty ring full time
# (in microseconds) each dirty ring full round. The value equals
# dirty ring memory size divided by average dirty page rate of the
# virtual CPU, which can be used to observe the average memory
# load of the virtual CPU indirectly. Note that zero means guest
# doesn't dirty memory. (Since 8.1)
> +#
> # Since: 0.14
> ##
> { 'struct': 'MigrationInfo',
> @@ -267,7 +279,9 @@
> '*postcopy-blocktime' : 'uint32',
> '*postcopy-vcpu-blocktime': ['uint32'],
> '*compression': 'CompressionStats',
> - '*socket-address': ['SocketAddress'] } }
> + '*socket-address': ['SocketAddress'],
> + '*dirty-limit-throttle-time-per-round': 'uint64',
> + '*dirty-limit-ring-full-time': 'uint64'} }
>
> ##
> # @query-migrate:
[...]
The issues I'm pointing out don't justfy yet another respin. But if you
need to respin the series for some other reason, plase take care of them.
