Hi Rui, On Thu, Jul 06, 2023 at 12:59:55PM -0400, Rui Chen wrote: > While upgrading capstone to v5, there was some name clash with the > tricore_feature in capstone (which was introduced in this PR), thus rename > tricore_feature to is_tricore_feature_enabled. > > Build error log is below > > /opt/homebrew/Cellar/capstone/5.0/include/capstone/tricore.h:561:3: error: > redefinition of 'tricore_feature' as different kind of symbol > } tricore_feature; > ^ > ../target/tricore/cpu.h:261:19: note: previous definition is here > static inline int tricore_feature(CPUTriCoreState *env, int feature) > ^ > 1 error generated.
I ran into the same problem when trying out capstone. I think a better name would be tricore_has_feature() to match has_feature() in target/tricore/translate.c. P.S. if you CC me it helps my mail filter to find your patch :). Also we have the rule for qemu-devel to not send a patch as a attachment. See (https://www.qemu.org/docs/master/devel/submitting-a-patch.html) Cheers, Bastian
