Hi Chris,
On 7/7/23 00:10, Chris Laplante wrote:
Hello all,
I have a test case that needs to intercept a named GPIO out interrupt.
qtest_irq_intercept_out doesn't support this currently. I would like to
send a patch to add this functionality. Does anyone have a preference if
I implement it is a new function (qtest_irq_intercept_out_named), vs add
the functionality to qtest_irq_intercept_out in the form of an optional
additional parameter?
qtest_irq_intercept_out() takes a QOM path argument. Whether it is
a named IRQ or not should be irrelevant at this layer.
IMO qtest_process_command() need to be improved to handle named IRQs,
see the "/* We don't support intercept of named GPIOs yet */" comment
from commit a5f54290ce ("qdev: Implement named GPIOs"). Few days later
commit 60a79016ae ("qtest/irq: Rework IRQ interception") improved the
support. Few is missing IMO.
Regards,
Phil.
