06.07.2023 18:08, Peng Liang wrote:
virt-acpi-build.c uses warn_report. However, it doesn't include qemu/error-report.h directly, it include qemu/error-report.h via trace.h if we enable log trace backend. But if we disable the log trace backend (e.g., --enable-trace-backends=nop), then virt-acpi-build.c will not include qemu/error-report.h any more and it will lead to build errors. Include qemu/error-report.h directly in virt-acpi-build.c to avoid the errors.
Applied to my trivial-patches tree, moving it higher as suggested by Ani (to sort more alphabetically) and adding the Fixes: line as suggested by Philippe. Thanks! /mjt