On 5/7/23 21:40, Mark Cave-Ayland wrote:
On 03/07/2023 09:26, Philippe Mathieu-Daudé wrote:
On 2/7/23 17:48, Mark Cave-Ayland wrote:
Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>
---
hw/block/swim.c | 14 ++++++++++++++
hw/block/trace-events | 7 +++++++
2 files changed, 21 insertions(+)
@@ -312,6 +322,7 @@ static uint64_t iwmctrl_read(void *opaque, hwaddr
reg, unsigned size)
swimctrl->regs[reg >> 1] = reg & 1;
+ trace_swim_iwmctrl_read((reg >> 1), size, (reg & 1));
return 0;
}
+swim_swimctrl_read(int reg, const char *name, unsigned size,
uint64_t value) "reg=%d [%s] size=%u value=0x%"PRIx64
+swim_swimctrl_write(int reg, const char *name, unsigned size,
uint64_t value) "reg=%d [%s] size=%u value=0x%"PRIx64
+swim_iwmctrl_read(int reg, unsigned size, uint64_t value) "reg=%d
size=%u value=0x%"PRIx64
+swim_iwmctrl_write(int reg, unsigned size, uint64_t value) "reg=%d
size=%u value=0x%"PRIx64
For these 2 functions, 'value' is 1 bit so could be 'unsigned' ;)
Indeed. In fact I'd be inclined to make them "unsigned int" just to be
sure there is no confusion :)
I thought the style was to just use "unsigned" but per
docs/devel/style.rst we indeed recommend "unsigned int". TIL.
