On 04/07/2023 11.32, Cédric Le Goater wrote:
It is useful to extend the number of available PCI devices to KVM guests
for passthrough scenarios and also to expose these models to a different
(big endian) architecture.

Maybe mention that these devices can work on s390x since they support MSI-X ? (While most of the other devices don't work on s390x since they only support legacy interrupts)

Signed-off-by: Cédric Le Goater <c...@redhat.com>
---
  hw/s390x/Kconfig | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/hw/s390x/Kconfig b/hw/s390x/Kconfig
index 5e7d8a2bae8b..373f38adcd6b 100644
--- a/hw/s390x/Kconfig
+++ b/hw/s390x/Kconfig
@@ -10,3 +10,7 @@ config S390_CCW_VIRTIO
      select SCLPCONSOLE
      select VIRTIO_CCW
      select MSI_NONBROKEN
+    select PCI_EXPRESS
+    select E1000E_PCI_EXPRESS
+    select IGB_PCI_EXPRESS
+    select USB_XHCI_PCI

Please don't use "select" here - you still want these devices to be disabled in case you run configure with "--without-default-devices".

You can use "imply" instead of "select" instead.

 Thomas


Reply via email to