On Fri, 16 Dec 2022 at 20:51, Taylor Simpson <tsimp...@quicinc.com> wrote: > > From: Anton Johansson <a...@rev.ng> > > Signed-off-by: Alessandro Di Federico <a...@rev.ng> > Signed-off-by: Paolo Montesel <bab...@rev.ng> > Signed-off-by: Anton Johansson <a...@rev.ng> > Signed-off-by: Taylor Simpson <tsimp...@quicinc.com> > Reviewed-by: Taylor Simpson <tsimp...@quicinc.com> > Message-Id: <20220923173831.227551-10-a...@rev.ng>
Hi; Coverity points out (CID 976926) that here: > --- /dev/null > +++ b/target/hexagon/idef-parser/idef-parser.y > +lvalue : FAIL > + { > + @1.last_column = @1.last_column; ...we have coded an "x = x" assignment that has no effect. Was this supposed to be something else, or should it just be deleted? > + yyassert(c, &@1, false, "Encountered a FAIL token as > lvalue.\n"); > + } > + | REG > + { > + $$ = $1; > + } > + | var > + { > + $$ = $1; > + } > + ; thanks -- PMM