Re: [PATCH v2 23/26] target/arm/tcg: Inline 'exec/helper-gen.h'

[Philippe Mathieu-Daudé]

On 14/6/23 07:01, Richard Henderson wrote:

On 6/11/23 10:58, Philippe Mathieu-Daudé wrote:

+++ b/target/arm/helper.c
@@ -26,6 +26,11 @@
  #include "qapi/error.h"
  #include "qemu/guest-random.h"
  #ifdef CONFIG_TCG
+
+#define HELPER_H "helper.h"
+#include "exec/helper-gen.h.inc"
+#undef  HELPER_H

Why is this here?  helper-gen is for tcg code generation, which should not be required at all in this file.  I can't see how the modification to translate.h affects this.

Indeed this is not needed.