On Jun 09 13:49, Richard Henderson wrote: > On 6/9/23 10:23, Aaron Lindsay wrote: > > --- a/target/arm/hvf/hvf.c > > +++ b/target/arm/hvf/hvf.c > > @@ -847,6 +847,7 @@ static bool > > hvf_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf) > > { HV_SYS_REG_ID_AA64DFR1_EL1, &host_isar.id_aa64dfr1 }, > > { HV_SYS_REG_ID_AA64ISAR0_EL1, &host_isar.id_aa64isar0 }, > > { HV_SYS_REG_ID_AA64ISAR1_EL1, &host_isar.id_aa64isar1 }, > > + { HV_SYS_REG_ID_AA64ISAR2_EL1, &host_isar.id_aa64isar2 }, > > Sadly not defined for MacOSX13.1.sdk, and it's an enum so you can't #ifdef it > either. > > You'll need a meson probe for it.
I'm not very familiar with HVF or meson - I am not sure I understand what you're suggesting here (and a few attempts to grep around for an example didn't turn up anything that looked helpful). Are you suggesting some sort of build-time auto-detection, a "dumb" configuration switch that a user could use to manually enable this, or something else? And/or is there an example you could point me to of what you're thinking? -Aaron