On Tue, 6 Jun 2023 at 16:50, Philippe Mathieu-Daudé <phi...@linaro.org> wrote:
>
> On 6/6/23 16:37, Richard Henderson wrote:
> > On 6/6/23 07:12, Philippe Mathieu-Daudé wrote:
> >> Since commit 139c1837db ("meson: rename included C source files
> >> to .c.inc"), QEMU standard procedure for included C files is to
> >> use *.c.inc.
> >>
> >> Besides, since commit 6a0057aa22 ("docs/devel: make a statement
> >> about includes") this is documented as the Coding Style:
> >>
> >> If you do use template header files they should be named with
> >> the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are
> >> being included for expansion.
> >>
> >> Therefore rename the included templates as '.h.inc'.
> >>
> >> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
> >
> > Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
> >
> > FYI, after yesterday's tcg pr, we can do more than this. These
> > fragments no longer have to be all included into one common helper.h.
> > Each translate-foo.c can include only the helper-foo.h.inc bits that
> > they need, and the bits need not be visible to the rest of the front end.
>
> Don't we need foo fully converted to decodetree first? Otherwise
> generic translate code can call foo helpers, so needs their prototype
> declaration.
>
> For example in translate-a64.c handle_msr_i(SVCR) calls
> gen_helper_set_svcr() which is declared in helper-sme.h.
That's unrelated to decodetree -- the decodetree conversion for
that instruction still has code in translate-a64.c which
calls gen_helper_set_svcr(), it's just in a different function.
https://patchew.org/QEMU/20230602155223.2040685-1-peter.mayd...@linaro.org/20230602155223.2040685-6-peter.mayd...@linaro.org/
thanks
-- PMM
