On Thu, Jun 1, 2023 at 9:45 AM Niklas Cassel <n...@flawful.org> wrote: > > From: Niklas Cassel <niklas.cas...@wdc.com> > > Hello John, > > Here comes some misc AHCI cleanups. > > Most are related to error handling. > > Please review. > > (I'm also working on a second series which will add support for > READ LOG EXT and READ LOG DMA EXT, but I will send that one out > once it is ready. (It might take a couple of weeks still, since > I've been a bit busy lately.)) > > > Changes since v1: > -Picked up Reviewed-by tags. > (I did not convert your ACK to explicit Acked-by tags, since I assume > that the patches will go via your tree).
Guess so! I haven't been involved with IDE for a minute so I left the ACKs in case I wandered off to signify that I hadn't reviewed them thoroughly, but they *looked* good. Since I haven't wandered off, guess I will actually take this and send an MR. I'll try to do this Friday, June 2nd. Thanks again for the very detailed commit messages, which make this easy. :) --js > -Rebased on master in order to fix a conflict in patch > "hw/ide/ahci: simplify and document PxCI handling". > -Dropped patch "hw/ide/ahci: trigger either error IRQ or regular IRQ, not > both" > for now, as it caused a boot time regression in SeaBIOS. > This appears to be a bug in SeaBIOS, for more info see: > > https://mail.coreboot.org/hyperkitty/list/seab...@seabios.org/thread/RIHV3FZ4EVMAJA4TEDPASKNYV7V72O4C/ > I will resend the QEMU patch separately once the SeaBIOS patch has been > merged, and once QEMU has updated to a SeaBIOS tag that includes the fix. > > > Kind regards, > Niklas > > Niklas Cassel (8): > hw/ide/ahci: remove stray backslash > hw/ide/core: set ERR_STAT in unsupported command completion > hw/ide/ahci: write D2H FIS on when processing NCQ command > hw/ide/ahci: simplify and document PxCI handling > hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set > hw/ide/ahci: PxSACT and PxCI is cleared when PxCMD.ST is cleared > hw/ide/ahci: fix ahci_write_fis_sdb() > hw/ide/ahci: fix broken SError handling > > hw/ide/ahci.c | 112 +++++++++++++++++++++++++++++++++++--------------- > hw/ide/core.c | 2 +- > 2 files changed, 81 insertions(+), 33 deletions(-) > > -- > 2.40.1 >
