On Thu, Jun 01, 2023 at 06:09:44PM +0200, Thomas Huth wrote: > On 01/06/2023 14.33, Juan Quintela wrote: > > Daniel P. Berrangé <berra...@redhat.com> wrote: > ... > > > On a test machine this reduces execution time from 13 minutes to > > > 8 minutes. > > > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > > > Hi > > > > I have a different idea to get the migration tests faster. Namely, just > > stop letting enter the completation stage until we are ready to use it. > > > > I need that functionality also for vfio migration, so as I have to > > create the patches, can we put on hold the last two patches and give me > > a couple of days? > > A couple of days are certainly OK ... but could we please avoid being stuck > in the current situation for many more weeks?
Also as I mentioned in my reply to Peter, I'm wary of an approach that puts in a synchronization between the test suite and the migrate code, because that's making migration run in a manner which doesn't actually match how it'll run in the real world. So I think if there was a feature to add a sync before the final iteration, we'd still want to test without using that feature so we get proper coverage. Could we merge this series as-is, and simply re-visit the last patch afterwards, once we have time to debate the feature about completion phase synchronization. > The slowness of the migration > tests are really slowing down my turnaround times, and I think they > contribute to the timeouts of the Travis CI tests that I'm currently facing, > and likely also contributed to the issue that the QEMU project ran out of > Gitlab CI minutes again last month (which is thankfully mostly hidden by the > new private Linux runners, but some things like the Windows runners were not > available anymore). So I'd appreciate if we'd rather get a speed up here > merged rather sooner than later. > > > Thomas, do you care if I get the whole sets of patches through the > > migration tree? > > That's fine, please take them through your tree! With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
