On 01/06/2023 13:07, Michael S. Tsirkin wrote:
On Thu, May 25, 2023 at 05:03:15PM +0100, Mark Cave-Ayland wrote:
On 23/05/2023 20:56, Bernhard Beschow wrote:
This series:
* Removes dead code from omap_uart and i82378
* Resolves redundant code in the i8254 timer devices
v3:
* Drop TYPE_ISA_PARALLEL since they became obsolete by
https://lore.kernel.org/qemu-devel/20230522115014.1110840-9-th...@redhat.com/
Oh I didn't see that this had already been merged :/
It's not a reason to block this series, but I'd still like to see your
changes to ParallelState and ISAParallelState merged separately since they
are a better match for our QOM coding standards.
v2:
* Export ParallelState and ISAParallelState (Mark)
Testing done:
* `make check`
Bernhard Beschow (3):
hw/timer/i8254_common: Share "iobase" property via base class
hw/arm/omap: Remove unused omap_uart_attach()
hw/isa/i82378: Remove unused "io" attribute
include/hw/arm/omap.h | 1 -
hw/char/omap_uart.c | 9 ---------
hw/i386/kvm/i8254.c | 1 -
hw/isa/i82378.c | 1 -
hw/timer/i8254.c | 6 ------
hw/timer/i8254_common.c | 6 ++++++
6 files changed, 6 insertions(+), 18 deletions(-)
Do we know who is going to pick up these series? I can send a PR if no-one
minds?
Go ahead:
Acked-by: Michael S. Tsirkin <m...@redhat.com>
Thanks Michael! Is there any objection to also including
https://patchew.org/QEMU/20230531211043.41724-1-shen...@gmail.com/ at the same time?
Bernhard: if you are able to submit a rebased version of the ISA_PARALLEL cleanups at
https://patchew.org/QEMU/20230521123049.312349-1-shen...@gmail.com/ I think it is
worth considering those for inclusion in the PR as well (note the comments re: an
updated commit message and register definitions, but I can't really do this myself
because of the missing SoB).
ATB,
Mark.
