Re: [PATCH v1 1/1] hw/arm/sbsa-ref: use XHCI to replace EHCI

[Philippe Mathieu-Daudé]

Hi Yuquan,

On 31/5/23 11:58, Yuquan Wang wrote:

The current sbsa-ref cannot use EHCI controller which is only
able to do 32-bit DMA, since sbsa-ref doesn't have RAM below 4GB.
Hence, this uses XHCI to provide a usb controller with 64-bit
DMA capablity instead of EHCI.

Signed-off-by: Yuquan Wang <wangyuquan1...@phytium.com.cn>
Change-Id: I1376f8bbc0e25dcd9d8a22b6e061cb56b3486394
---
  hw/arm/sbsa-ref.c | 16 ++++++++--------
  1 file changed, 8 insertions(+), 8 deletions(-)

-static void create_ehci(const SBSAMachineState *sms)
+static void create_xhci(const SBSAMachineState *sms)
  {
-    hwaddr base = sbsa_ref_memmap[SBSA_EHCI].base;
-    int irq = sbsa_ref_irqmap[SBSA_EHCI];
+    hwaddr base = sbsa_ref_memmap[SBSA_XHCI].base;
+    int irq = sbsa_ref_irqmap[SBSA_XHCI];

- sysbus_create_simple("platform-ehci-usb", base

+    sysbus_create_simple("sysbus-xhci", base,

Please use the definition: TYPE_XHCI_SYSBUS.

                           qdev_get_gpio_in(sms->gic, irq));
  }