Richard Henderson <richard.hender...@linaro.org> wrote: > On 5/30/23 11:25, Juan Quintela wrote: >> The following changes since commit aa9bbd865502ed517624ab6fe7d4b5d89ca95e43: >> Merge tag 'pull-ppc-20230528' of https://gitlab.com/danielhb/qemu >> into staging (2023-05-29 14:31:52 -0700) >> are available in the Git repository at: >> https://gitlab.com/juan.quintela/qemu.git >> tags/migration-20230530-pull-request >> for you to fetch changes up to >> c63c544005e6b1375a9c038f0e0fb8dfb8b249f4: >> migration/rdma: Check sooner if we are in postcopy for >> save_page() (2023-05-30 19:23:50 +0200) >> ---------------------------------------------------------------- >> Migration 20230530 Pull request (take 2) >> Hi >> Resend last PULL request, this time it compiles when CONFIG_RDMA is >> not configured in. >> [take 1] >> On this PULL request: >> - Set vmstate migration failure right (vladimir) >> - Migration QEMUFileHook removal (juan) >> - Migration Atomic counters (juan) >> Please apply. >> ---------------------------------------------------------------- >> Juan Quintela (16): >> migration: Don't abuse qemu_file transferred for RDMA >> migration/RDMA: It is accounting for zero/normal pages in two places >> migration/rdma: Remove QEMUFile parameter when not used >> migration/rdma: Don't use imaginary transfers >> migration: Remove unused qemu_file_credit_transfer() >> migration/rdma: Simplify the function that saves a page >> migration: Create migrate_rdma() >> migration/rdma: Unfold ram_control_before_iterate() >> migration/rdma: Unfold ram_control_after_iterate() >> migration/rdma: Remove all uses of RAM_CONTROL_HOOK >> migration/rdma: Unfold hook_ram_load() >> migration/rdma: Create rdma_control_save_page() >> qemu-file: Remove QEMUFileHooks >> migration/rdma: Move rdma constants from qemu-file.h to rdma.h >> migration/rdma: Remove qemu_ prefix from exported functions >> migration/rdma: Check sooner if we are in postcopy for save_page() >> Vladimir Sementsov-Ogievskiy (5): >> runstate: add runstate_get() >> migration: never fail in global_state_store() >> runstate: drop unused runstate_store() >> migration: switch from .vm_was_running to .vm_old_state >> migration: restore vmstate on migration failure
Self nack > Appears to introduce multiple avocado failures: > > https://gitlab.com/qemu-project/qemu/-/jobs/4378066518#L286 > > Test summary: > tests/avocado/migration.py:X86_64.test_migration_with_exec: ERROR No clue what is going on here. I haven't touched exec migration (famous last words) > tests/avocado/migration.py:X86_64.test_migration_with_tcp_localhost: > ERROR This is tested by ./tests/migration-test It passes for me with qemu-system-x86_64 (kvm), qemu-system-i386 (kvm) and aarch64 (tcg). What make check tests. > tests/avocado/migration.py:X86_64.test_migration_with_unix: ERROR Dunno again. > make: *** [/builds/qemu-project/qemu/tests/Makefile.include:142: > check-avocado] Error 1 > > https://gitlab.com/qemu-project/qemu/-/jobs/4378066523#L387 > > Test summary: > tests/avocado/migration.py:X86_64.test_migration_with_tcp_localhost: ERROR > tests/avocado/migration.py:X86_64.test_migration_with_unix: ERROR > make: *** [/builds/qemu-project/qemu/tests/Makefile.include:142: > check-avocado] Error 1 > > Also fails QTEST_QEMU_BINARY=./qemu-system-aarch64 > ./tests/qtest/migration-test > > ../src/migration/rdma.c:408:QIO_CHANNEL_RDMA: Object 0xaaaaf7bba680 is This is something that changed on the series, so I will check with this avocado tests. No clue why it passes with x86_64 and not with aarch64. > not an instance of type qio-channel-rdma Here there was an error creating the RDMA channel somehow. Somehow is the important word on the previous sentence. > qemu-system-aarch64: Not a migration stream > qemu-system-aarch64: load of migration failed: Invalid argument > Broken pipe Will isolate the non RDMA changes and try to pass the RDMA ones through avocado. I am sorry for the noise. Later, Juan.
