Leonardo Bras Soares Passos <leob...@redhat.com> wrote:
> On Fri, May 26, 2023 at 5:04 AM Juan Quintela <quint...@redhat.com> wrote:
>> > Maybe too much?
>>
>> I dropped this patch for two reasons:
>>
>> - reviewers gave me a bad time with it O:-)
>> - it was there only so if anyone was meassuring that new counters are
>> the same that old counters.
>>
>> But as I have already checked that, we don't need it.
>>
>> I drop it on the next round that I send.
>> > Maybe, it would be nice to have qemu_put_* to return the value, and in this
>> > case:
>> >
>> > size += qemu_put_be64(...)
>> >
>> > What do you think?
>>
>> Even more important than that is to return an error value, but that
>> is a very long project.
>>
>> See on my next series that qemu_fflush() return errors, so code gets
>> simplifed:
>>
>> qemu_fflush(file);
>> if (qemu_file_get_error(file)) {
>> handle error;
>> }
>>
>> to:
>>
>> qemu_fflush(file);
>> if (qemu_file_get_error(file)) {
>> handle error;
>> }
>>
>
> They look the same to me, what changed?
I did copy paste without changing:
if (qemu_fflush(file)) {
handle error;
}
>> We need to do basically all qemu_put_*() and qemu_get_*() functions, but
>> it is a step on the right direction.
>>
>> Later, Juan.
>>
