Re: [PATCH v4 6/9] vfio/migration: Store VFIO migration flags in VFIOMigration

[Cédric Le Goater]

On 5/28/23 16:06, Avihai Horon wrote:

VFIO migration flags are queried once in vfio_migration_init(). Store
them in VFIOMigration so they can be used later to check the device's
migration capabilities without re-querying them.

This will be used in the next patch to check if the device supports
precopy migration.

Signed-off-by: Avihai Horon <avih...@nvidia.com>

Reviewed-by: Cédric Le Goater <c...@redhat.com>

Thanks,

C.

---
  include/hw/vfio/vfio-common.h | 1 +
  hw/vfio/migration.c           | 1 +
  2 files changed, 2 insertions(+)

diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
index eed244f25f..5f29dab839 100644
--- a/include/hw/vfio/vfio-common.h
+++ b/include/hw/vfio/vfio-common.h
@@ -66,6 +66,7 @@ typedef struct VFIOMigration {
      int data_fd;
      void *data_buffer;
      size_t data_buffer_size;
+    uint64_t mig_flags;
  } VFIOMigration;

typedef struct VFIOAddressSpace {

diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
index 235978fd68..8d33414379 100644
--- a/hw/vfio/migration.c
+++ b/hw/vfio/migration.c
@@ -603,6 +603,7 @@ static int vfio_migration_init(VFIODevice *vbasedev)
      migration->vbasedev = vbasedev;
      migration->device_state = VFIO_DEVICE_STATE_RUNNING;
      migration->data_fd = -1;
+    migration->mig_flags = mig_flags;

vbasedev->dirty_pages_supported = vfio_dma_logging_supported(vbasedev);