This series started with the last patch, an iotest that tests the fixes
for .bdrv_co_create() that were made in commit b2ab5f545f ('block:
bdrv/blk_co_unref() for calls in coroutine context').Unfortunately, it turned out that much more is wrong about creating images in an iothread. In particular, AioContext locking is messy and in many cases wrong. (Only one more reason to get rid of them.) This series fixes all the hangs and crashes I saw while making the final test case pass. Note that this series isn't fully bisectable. Some of the existing bugs cancel each other out, so after fixing one, some test cases will break until the other one is fixed, too. Kevin Wolf (12): block-coroutine-wrapper: Take AioContext lock in no_co_wrappers block: Clarify locking rules for bdrv_open(_inherit)() block: Take main AioContext lock when calling bdrv_open() block-backend: Fix blk_new_open() for iothreads mirror: Hold main AioContext lock for calling bdrv_open_backing_file() qcow2: Fix open with 'file' in iothread raw-format: Fix open with 'file' in iothread copy-before-write: Fix open with child in iothread block: Take AioContext lock in bdrv_open_driver() block: Fix AioContext locking in bdrv_insert_node() iotests: Make verify_virtio_scsi_pci_or_ccw() public iotests: Test blockdev-create in iothread include/block/block-common.h | 3 + block.c | 33 ++++++--- block/block-backend.c | 36 ++++++++-- block/copy-before-write.c | 21 ++++-- block/mirror.c | 6 ++ block/qapi-sysemu.c | 3 + block/qcow2.c | 8 ++- block/raw-format.c | 5 ++ blockdev.c | 29 ++++++-- qemu-nbd.c | 4 ++ tests/unit/test-block-iothread.c | 4 +- scripts/block-coroutine-wrapper.py | 25 ++++--- tests/qemu-iotests/iotests.py | 2 +- tests/qemu-iotests/256 | 2 +- tests/qemu-iotests/tests/iothreads-create | 67 +++++++++++++++++++ tests/qemu-iotests/tests/iothreads-create.out | 4 ++ 16 files changed, 210 insertions(+), 42 deletions(-) create mode 100755 tests/qemu-iotests/tests/iothreads-create create mode 100644 tests/qemu-iotests/tests/iothreads-create.out -- 2.40.1
