RE: [PATCH 2/2] Hexagon: fix outdated `hex_new_*` references in comments

[Taylor Simpson]

> -----Original Message-----
> From: Matheus Tavares Bernardino <quic_mathb...@quicinc.com>
> Sent: Tuesday, May 23, 2023 3:36 PM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson <tsimp...@quicinc.com>; Brian Cain
> <bc...@quicinc.com>; Marco Liebel (QUIC) <quic_mlie...@quicinc.com>
> Subject: [PATCH 2/2] Hexagon: fix outdated `hex_new_*` references in
> comments
> 
> Some code comments refer to hex_new_value and hex_new_pred_value,
> which have been transferred to DisasContext and, in the case of
> hex_new_value, should now be accessed through get_result_gpr(). Let's
> update these comments to reflect the new state of the codebase. Since they
> are only meant to assist developers, we can replace the old names with some
> pseudocode when convenient.
> 
> Signed-off-by: Matheus Tavares Bernardino <quic_mathb...@quicinc.com>
> ---
>  target/hexagon/genptr.c    | 10 +++++-----
>  target/hexagon/translate.c |  2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index
> cb2aa28a19..8d11d928c9 100644
> --- a/target/hexagon/genptr.c
> +++ b/target/hexagon/genptr.c
> @@ -880,7 +880,7 @@ static void gen_endloop0(DisasContext *ctx)
>          /*
>           *    if (hex_gpr[HEX_REG_LC0] > 1) {
>           *        PC = hex_gpr[HEX_REG_SA0];
> -         *        hex_new_value[HEX_REG_LC0] = hex_gpr[HEX_REG_LC0] - 1;
> +         *        result_gpr(HEX_REG_LC0) = hex_gpr[HEX_REG_LC0] - 1;
>           *    }
>           */

Go ahead and change these completely to pseudo-code
    If (LC0 > 1) {
        PC = SA0;
        LC0 = LC0 - 1;
    }

Thanks,
Taylor