On 5/18/23 18:16, Wu, Fei wrote:
On 4/22/2023 12:42 AM, Alex Bennée wrote:
Fei Wu <fei2...@intel.com> writes:
This patch series were done by Vanderson and Alex originally in 2019, I
(Fei Wu) rebased them on latest upstream from:
https://github.com/stsquad/qemu/tree/tcg/tbstats-and-perf-v10
and send out this review per Alex's request, I will continue to address
any future review comments here. As it's been a very long time and there
are lots of conflicts during rebase, it's my fault if I introduce any
problems during the process.
Hi Fei,
Thanks for picking this up. I can confirm that this applies cleanly to
master and I have kicked the tyres and things still seem to work. I'm
not sure if I can provide much review on code I wrote but a few things
to point out:
- there are a number of CI failures, mainly qatomic on 32 bit guests
see https://gitlab.com/stsquad/qemu/-/pipelines/844857279/failures
maybe we just disable time accounting for 32 bit hosts?
I sent out v12 series which fixes some CI failures. qatomic is not
touched yet, the current code with CONFIG_PROFILER should have the same
issue, what's the policy of 32 bit guests support on qemu?
They should work.
Besides time, there are some other counters with uint64_t using qatomic
such as TCGProfile.table_op_count, we might switch to size_t instead?
Probably. You probably don't need to represent times as uint64_t (or time64_t), but as
differentials for elapsed time.
We could accumulate into 'float' if you were concerned about overflowing 2^32 units. This
is statistics after all; we don't really need exact numbers, we need magnitude and 2-3
digits of precision.
r~
