Hi Mostafa, Peter On 5/15/23 15:03, Mostafa Saleh wrote: > Hi Peter, > > On Fri, May 12, 2023 at 03:46:43PM +0100, Peter Maydell wrote: >> Mostafa: is there anything in particular here that means this >> patchset should stay an RFC and isn't ready to go into the tree? > No, I believe the series is in a good shape now. > I will remove RFC when sending v4, if Eric has not major findings.
Yes I think you need to turn this into a PATCH set now. I had no big comments to be taken into account. I tested this against non regressions with S1 and I did not spot anything bad. Also I tested migration between this and original implementation and it went gently. Thanks Eric > > Thanks, > Mostafa >