> In addition, I don't see that the listener thread holds any lock while it reads the image. I guess that during that period the guest runs and may race w/ this new thread.
Yes - I mentioned that in the patch mail as one of the open issues. Can you direct me to the lock I need? The function I call from a new thread context is bdrv_aio_readv. -----Original Message----- From: Dor Laor [mailto:dl...@redhat.com] Sent: Tuesday, February 07, 2012 2:25 PM To: Anthony Liguori Cc: Ori Mamluk; Kevin Wolf; qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [RFC PATCH] replication agent module On 02/07/2012 02:12 PM, Anthony Liguori wrote: > Hi, > > On 02/07/2012 04:29 AM, Ori Mamluk wrote: >> Repagent is a new module that allows an external replication system >> to replicate a volume of a Qemu VM. >> >> This RFC patch adds the repagent client module to Qemu. > > Please read http://wiki.qemu.org/Contribute/SubmitAPatch > > In particular, use a tool like git-send-email and split this patch up > into more manageable chunks. > > Is there an Open Source rehub available? As a project policy, adding > external APIs specifically for proprietary software is not something > we're willing to do. > > Regards, > > Anthony Liguori In addition, I don't see that the listener thread holds any lock while it reads the image. I guess that during that period the guest runs and may race w/ this new thread. About image ID for the replication hub, you can use the VM's pid or VM's uuid paired w/ the specific disk uuid Thanks, Dor
