On Wed, 10 May 2023 at 21:38, Kevin Wolf <kw...@redhat.com> wrote: > > There are some error paths in blk_exp_add() that jump to 'fail:' before > 'exp' is even created. So we can't just unconditionally access exp->blk. > > Add a NULL check, and switch from exp->blk to blk, which is available > earlier, just to be extra sure that we really cover all cases where > BlockDevOps could have been set for it (in practice, this only happens > in drv->create() today, so this part of the change isn't strictly > necessary). > > Fixes: de79b52604e43fdeba6cee4f5af600b62169f2d2 > Signed-off-by: Kevin Wolf <kw...@redhat.com> > ---
Coverity noticed this bug, incidentally: CID 1509238. -- PMM
