Richard Henderson <richard.hender...@linaro.org> writes:
> We only need to make copies for loads, when the destination > overlaps the address. For now, only eliminate the copy for > stores and 128-bit loads. > > Rename plugin_prep_mem_callbacks to plugin_maybe_preserve_addr, > returning NULL if no copy is made. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > tcg/tcg-op-ldst.c | 38 ++++++++++++++++++++------------------ > 1 file changed, 20 insertions(+), 18 deletions(-) > > diff --git a/tcg/tcg-op-ldst.c b/tcg/tcg-op-ldst.c > index 17fe35b93c..cbd85f793c 100644 > --- a/tcg/tcg-op-ldst.c > +++ b/tcg/tcg-op-ldst.c > @@ -114,7 +114,8 @@ static void tcg_gen_req_mo(TCGBar type) > } > } > > -static inline TCGv plugin_prep_mem_callbacks(TCGv vaddr) > +/* Only required for loads, where value might overlap addr. */ maybe mention we don't bother checking if the temps actually overlap because we will need to futz around with the copy of addr for plugins. Otherwise: Reviewed-by: Alex Bennée <alex.ben...@linaro.org> -- Alex Bennée Virtualisation Tech Lead @ Linaro
