On Wed, May 10, 2023 at 05:13:03PM +0100, Richard Henderson wrote: > On 5/10/23 16:32, Stafford Horne wrote: > > void HELPER(mtspr)(CPUOpenRISCState *env, target_ulong spr, target_ulong > > rb) > > { > > -#ifndef CONFIG_USER_ONLY > > OpenRISCCPU *cpu = env_archcpu(env); > > +#ifndef CONFIG_USER_ONLY > > CPUState *cs = env_cpu(env); > > Pulled cpu out if ifdef here... > > > @@ -204,10 +220,22 @@ target_ulong HELPER(mfspr)(CPUOpenRISCState *env, > > target_ulong rd, > > OpenRISCCPU *cpu = env_archcpu(env); > > CPUState *cs = env_cpu(env); > > int idx; > > +#else > > + OpenRISCCPU *cpu = env_archcpu(env); > > #endif > > But replicated it here.
Right, let me make it consistent in this patch. > Otherwise, > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> Thank you, -Stafford