Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> wrote: > We don't allow to use x-colo capability when replication is not > configured. So, no reason to build COLO when replication is disabled, > it's unusable in this case. > > Note also that the check in migrate_caps_check() is not the only > restriction: some functions in migration/colo.c will just abort if > called with not defined CONFIG_REPLICATION, for example: > > migration_iteration_finish() > case MIGRATION_STATUS_COLO: > migrate_start_colo_process() > colo_process_checkpoint() > abort() > > It could probably make sense to have possibility to enable COLO without > REPLICATION, but this requires deeper audit of colo & replication code, > which may be done later if needed. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> > Acked-by: Dr. David Alan Gilbert <d...@treblig.org>
Reviewed-by: Juan Quintela <quint...@redhat.com>
