On Mon, May 08, 2023 at 03:03:38PM -0500, Eric Blake wrote: > Add some more strings that the user might send our way. In > particular, some of these additions include FIXME comments showing > where our parser doesn't quite behave the way we want. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > tests/unit/test-cutils.c | 226 +++++++++++++++++++++++++++++++++++++-- > 1 file changed, 215 insertions(+), 11 deletions(-) >
> @@ -2704,13 +2749,30 @@ static void test_qemu_strtosz_invalid(void) > > str = " \t "; > endptr = NULL; > + res = 0xbaadf00d; > err = qemu_strtosz(str, &endptr, &res); > g_assert_cmpint(err, ==, -EINVAL); > g_assert_cmphex(res, ==, 0xbaadf00d); > g_assert_true(endptr == str); > > + str = "."; > + endptr = NULL; > + res = 0xbaadf00d; > + err = qemu_strtosz(str, &endptr, &res); > + g_assert_cmpint(err, ==, -EINVAL); > + g_assert_cmphex(res, ==, 0xbaadf00d); > + g_assert(endptr == str); Rebase botch. I should be using g_assert_true() here in line with earlier in the series. I think I cleaned it up later in the series, but shouldn't be churning on it that badly. Looks like I get to send a v2 to fix this and other things; I'll wait another day for other reviews first. (That's what I get for rearranging patches after the fact for a nicer presentation order...) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
