On Thu, 6 Apr 2023 at 16:54, Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > On 6/4/23 17:37, Peter Maydell wrote: > > Coverity points out (in CID 1508390) that write_bootloader has > > some dead code, where we assign to 'p' and then in the following > > line assign to it again. This happened as a result of the > > refactoring in commit cd5066f8618b. > > > > Fix the dead code by removing the 'void *v' variable entirely and > > instead adding a cast when calling bl_setup_gt64120_jump_kernel(), as > > we do at its other callsite in write_bootloader_nanomips(). > > > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > --- > > hw/mips/malta.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Are you planning to take this into a mips pullreq? If not, I can throw it into my next target-arm series. thanks -- PMM
