On Fri, Jan 27, 2012 at 11:09:21AM +0100, Andreas Färber wrote:
> Am 27.01.2012 08:27, schrieb Stefan Hajnoczi:
> > From: Jan Kiszka <jan.kis...@web.de>
> > 
> > By using strncasecmp, we allow for arbitrary characters after the
> > "on"/"off" string. Fix this by switching to strcasecmp.
> > 
> > Reviewed-by: Andreas Färber <afaer...@suse.de>
> > Reviewed-by: Markus Armbruster <arm...@redhat.com>
> > Signed-off-by: Jan Kiszka <jan.kis...@siemens.com>
> > Signed-off-by: Stefan Hajnoczi <stefa...@linux.vnet.ibm.com>
> 
> FWIW the ordering is wrong here. The tags are supposed to document the
> patch flow: The patch was first signed off by the author (Jan), then
> reviewed, then signed off by committers. Not first reviewed.
> 
> No need to respin but please keep in mind for the future.
> (Yeah, did that wrong myself before.)

Okay, thanks.

Stefan


Reply via email to