On 2023/05/04 22:10, Tomasz Dzieciol wrote:
Rename E1000E_RingInfo_st and E1000E_RingInfo according to qemu typdefs guide.

Please make the same change for e1000e to make it easy to compare it with igb.


Signed-off-by: Tomasz Dzieciol <t.dziec...@partner.samsung.com>
---
  hw/net/igb_core.c | 42 +++++++++++++++++++++---------------------
  1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 012eb1e1b9..b6031dea24 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -694,24 +694,24 @@ static uint32_t igb_rx_wb_eic(IGBCore *core, int 
queue_idx)
      return (ent & E1000_IVAR_VALID) ? BIT(ent & 0x1f) : 0;
  }
-typedef struct E1000E_RingInfo_st {
+typedef struct E1000ERingInfo {
      int dbah;
      int dbal;
      int dlen;
      int dh;
      int dt;
      int idx;
-} E1000E_RingInfo;
+} E1000ERingInfo;
static inline bool
-igb_ring_empty(IGBCore *core, const E1000E_RingInfo *r)
+igb_ring_empty(IGBCore *core, const E1000ERingInfo *r)
  {
      return core->mac[r->dh] == core->mac[r->dt] ||
                  core->mac[r->dt] >= core->mac[r->dlen] / E1000_RING_DESC_LEN;
  }
static inline uint64_t
-igb_ring_base(IGBCore *core, const E1000E_RingInfo *r)
+igb_ring_base(IGBCore *core, const E1000ERingInfo *r)
  {
      uint64_t bah = core->mac[r->dbah];
      uint64_t bal = core->mac[r->dbal];
@@ -720,13 +720,13 @@ igb_ring_base(IGBCore *core, const E1000E_RingInfo *r)
  }
static inline uint64_t
-igb_ring_head_descr(IGBCore *core, const E1000E_RingInfo *r)
+igb_ring_head_descr(IGBCore *core, const E1000ERingInfo *r)
  {
      return igb_ring_base(core, r) + E1000_RING_DESC_LEN * core->mac[r->dh];
  }
static inline void
-igb_ring_advance(IGBCore *core, const E1000E_RingInfo *r, uint32_t count)
+igb_ring_advance(IGBCore *core, const E1000ERingInfo *r, uint32_t count)
  {
      core->mac[r->dh] += count;
@@ -736,7 +736,7 @@ igb_ring_advance(IGBCore *core, const E1000E_RingInfo *r, uint32_t count)
  }
static inline uint32_t
-igb_ring_free_descr_num(IGBCore *core, const E1000E_RingInfo *r)
+igb_ring_free_descr_num(IGBCore *core, const E1000ERingInfo *r)
  {
      trace_e1000e_ring_free_space(r->idx, core->mac[r->dlen],
                                   core->mac[r->dh],  core->mac[r->dt]);
@@ -755,13 +755,13 @@ igb_ring_free_descr_num(IGBCore *core, const 
E1000E_RingInfo *r)
  }
static inline bool
-igb_ring_enabled(IGBCore *core, const E1000E_RingInfo *r)
+igb_ring_enabled(IGBCore *core, const E1000ERingInfo *r)
  {
      return core->mac[r->dlen] > 0;
  }
typedef struct IGB_TxRing_st {
-    const E1000E_RingInfo *i;
+    const E1000ERingInfo *i;
      struct igb_tx *tx;
  } IGB_TxRing;
@@ -774,7 +774,7 @@ igb_mq_queue_idx(int base_reg_idx, int reg_idx)
  static inline void
  igb_tx_ring_init(IGBCore *core, IGB_TxRing *txr, int idx)
  {
-    static const E1000E_RingInfo i[IGB_NUM_QUEUES] = {
+    static const E1000ERingInfo i[IGB_NUM_QUEUES] = {
          { TDBAH0, TDBAL0, TDLEN0, TDH0, TDT0, 0 },
          { TDBAH1, TDBAL1, TDLEN1, TDH1, TDT1, 1 },
          { TDBAH2, TDBAL2, TDLEN2, TDH2, TDT2, 2 },
@@ -800,13 +800,13 @@ igb_tx_ring_init(IGBCore *core, IGB_TxRing *txr, int idx)
  }
typedef struct E1000E_RxRing_st {
-    const E1000E_RingInfo *i;
+    const E1000ERingInfo *i;
  } E1000E_RxRing;
static inline void
  igb_rx_ring_init(IGBCore *core, E1000E_RxRing *rxr, int idx)
  {
-    static const E1000E_RingInfo i[IGB_NUM_QUEUES] = {
+    static const E1000ERingInfo i[IGB_NUM_QUEUES] = {
          { RDBAH0, RDBAL0, RDLEN0, RDH0, RDT0, 0 },
          { RDBAH1, RDBAL1, RDLEN1, RDH1, RDT1, 1 },
          { RDBAH2, RDBAL2, RDLEN2, RDH2, RDT2, 2 },
@@ -833,7 +833,7 @@ igb_rx_ring_init(IGBCore *core, E1000E_RxRing *rxr, int idx)
  static uint32_t
  igb_txdesc_writeback(IGBCore *core, dma_addr_t base,
                       union e1000_adv_tx_desc *tx_desc,
-                     const E1000E_RingInfo *txi)
+                     const E1000ERingInfo *txi)
  {
      PCIDevice *d;
      uint32_t cmd_type_len = le32_to_cpu(tx_desc->read.cmd_type_len);
@@ -866,7 +866,7 @@ igb_txdesc_writeback(IGBCore *core, dma_addr_t base,
  }
static inline bool
-igb_tx_enabled(IGBCore *core, const E1000E_RingInfo *txi)
+igb_tx_enabled(IGBCore *core, const E1000ERingInfo *txi)
  {
      bool vmdq = core->mac[MRQC] & 1;
      uint16_t qn = txi->idx;
@@ -883,7 +883,7 @@ igb_start_xmit(IGBCore *core, const IGB_TxRing *txr)
      PCIDevice *d;
      dma_addr_t base;
      union e1000_adv_tx_desc desc;
-    const E1000E_RingInfo *txi = txr->i;
+    const E1000ERingInfo *txi = txr->i;
      uint32_t eic = 0;
if (!igb_tx_enabled(core, txi)) {
@@ -918,7 +918,7 @@ igb_start_xmit(IGBCore *core, const IGB_TxRing *txr)
  }
static uint32_t
-igb_rxbufsize(IGBCore *core, const E1000E_RingInfo *r)
+igb_rxbufsize(IGBCore *core, const E1000ERingInfo *r)
  {
      uint32_t srrctl = core->mac[E1000_SRRCTL(r->idx) >> 2];
      uint32_t bsizepkt = srrctl & E1000_SRRCTL_BSIZEPKT_MASK;
@@ -930,7 +930,7 @@ igb_rxbufsize(IGBCore *core, const E1000E_RingInfo *r)
  }
static bool
-igb_has_rxbufs(IGBCore *core, const E1000E_RingInfo *r, size_t total_size)
+igb_has_rxbufs(IGBCore *core, const E1000ERingInfo *r, size_t total_size)
  {
      uint32_t bufs = igb_ring_free_descr_num(core, r);
      uint32_t bufsize = igb_rxbufsize(core, r);
@@ -1522,7 +1522,7 @@ igb_write_to_rx_buffers(IGBCore *core,
  }
static void
-igb_update_rx_stats(IGBCore *core, const E1000E_RingInfo *rxi,
+igb_update_rx_stats(IGBCore *core, const E1000ERingInfo *rxi,
                      size_t pkt_size, size_t pkt_fcs_size)
  {
      eth_pkt_types_e pkt_type = net_rx_pkt_get_packet_type(core->rx_pkt);
@@ -1540,7 +1540,7 @@ igb_update_rx_stats(IGBCore *core, const E1000E_RingInfo 
*rxi,
  }
static inline bool
-igb_rx_descr_threshold_hit(IGBCore *core, const E1000E_RingInfo *rxi)
+igb_rx_descr_threshold_hit(IGBCore *core, const E1000ERingInfo *rxi)
  {
      return igb_ring_free_descr_num(core, rxi) ==
             ((core->mac[E1000_SRRCTL(rxi->idx) >> 2] >> 20) & 31) * 16;
@@ -1562,7 +1562,7 @@ igb_write_packet_to_guest(IGBCore *core, struct NetRxPkt 
*pkt,
      struct iovec *iov = net_rx_pkt_get_iovec(pkt);
      size_t size = net_rx_pkt_get_total_len(pkt);
      size_t total_size = size + e1000x_fcs_len(core->mac);
-    const E1000E_RingInfo *rxi = rxr->i;
+    const E1000ERingInfo *rxi = rxr->i;
      size_t bufsize = igb_rxbufsize(core, rxi);
d = pcie_sriov_get_vf_at_index(core->owner, rxi->idx % 8);
@@ -1643,7 +1643,7 @@ igb_write_packet_to_guest(IGBCore *core, struct NetRxPkt 
*pkt,
  }
static bool
-igb_rx_strip_vlan(IGBCore *core, const E1000E_RingInfo *rxi)
+igb_rx_strip_vlan(IGBCore *core, const E1000ERingInfo *rxi)
  {
      if (core->mac[MRQC] & 1) {
          uint16_t pool = rxi->idx % IGB_NUM_VM_POOLS;

Reply via email to