Thomas Huth <th...@redhat.com> wrote:
> On 28/04/2023 12.34, Richard Henderson wrote:
>> Drop inline marker: let compiler decide.
>> Change return type to uint64_t: this matches the computation in the
>> return statement and the local variable assignment in the caller.
>> Rename local to dirty_ring_size_MB to fix typo.
>> Simplify conversion to MiB via qemu_target_page_bits and right shift.
>> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>

Reviewed-by: Juan Quintela <quint...@redhat.com>

Not that I expect the amount of bytes in one machine to not fit in
64bit, but good change.

About the signesdness of variables, I really hate it, specially that
compiler not help here where arguments, operands and assignment place is
unsigned.  Sniff.


Reply via email to