Juan Quintela <quint...@redhat.com> writes: > Fabiano Rosas <faro...@suse.de> wrote: >> Juan Quintela <quint...@redhat.com> writes: >> >>> We don't wait in the sem when we are doing a sync_main. Make it wait >>> there. To make things clearer, we mark the channel ready at the >>> begining of the thread loop. >> >> So in other words we're estabilishing that "channel ready" means ready >> to send, regardless of having sent the sync packet. Is that it? > > Yeap. > > There was a bug (from the beggining) that made the counter always get > up and up. This fixes it. > > It was always supposed to work this way.
Ah, great. I'm proposing a multifd variant without the sync packet in my fixed-ram series and moving the channels_ready to the top of the loop means I can stop issuing an extra qemu_sem_post(&p->sem) just to skip the sync packet.